Tolerate leading v in version string #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
approved these changes
Nov 16, 2023
|
Nothing is supposed to use portable-atomic at this point 😭 |
|
cc: @georgik was this an intended change? |
|
executor is pinned, CI is green now. |
|
@bugadani Which OS? We needed to build some targets manually, so |
|
Windows for me. I actually don't think this is a big deal, the version string already doesn't conform to semver anyway, and now with the workaround I'm fine either way. |
|
Ok, thank you for the confirmation. Based on other issue we will consider rebuild on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
espressif's rustc started including a
vin front of the version number with 1.74, likerustc 1.74.0-nightly (bd6bb31df 2023-11-15) (v1.74.0.0)