Add features to disable various network protocols #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me but we should also list the features in https://github.com/esp-rs/esp-wifi#features |
Disable smoltcp if none of them is enabled, as well. Restructure the cargo features to make this possible: utils isn't needed unless one of the protocols is on, but embedded-svc is needed even for sending and receiving raw frames. In order to do the latter, we also need a receive and transmit method on the WifiDevice, rather than using the methods on the smoltcp Device impl -- and we don't need to give them an Instant. Copy the implementation.
Also fix up a couple references in old ones.
|
Good point; done. |
bjoernQ
approved these changes
Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smoltcp has feature flags to allow enabling and disabling several protocols. Expose those feature flags to users of esp-wifi as well, to let them trim down both esp-wifi and smoltcp.
Also added a loop to the CI config to build with all combinations of all these new feature flags, to ensure all the possible combinations continue to work.
Fixes #290