Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify multitasking #334

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Simplify multitasking #334

merged 1 commit into from
Nov 3, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 3, 2023

My hypothesis is that we can get rid of the FIRST_SWITCH flag, saving a few instructions on each task switch.

I hope this works on RISC-V but we can restore the flag on it if not.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 3, 2023

Works fine on all targets - just one thing:

warning: unused import: `core::sync::atomic::Ordering`
 --> esp-wifi\src\timer\riscv.rs:2:5
  |
2 | use core::sync::atomic::Ordering;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernQ bjoernQ merged commit 7403b39 into esp-rs:main Nov 3, 2023
7 checks passed
@bugadani bugadani deleted the task branch November 3, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants