Skip to content

Bump minimum required cargo-generate version #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 21, 2023

Just did some testing and verified that 0.17.4 is the required version for shorten git URLs to work.

This version was released in Dec 2022, if you think we shouldn't force the user to such “recent” version (although updating cargo-generate does not hurt) we could go back to the full URL

@SergioGasquez SergioGasquez requested a review from bjoernQ April 21, 2023 08:57
@SergioGasquez SergioGasquez linked an issue Apr 21, 2023 that may be closed by this pull request
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I totally agree we should use a sane recent version - this version is more than a half year old so we can safely require it 👍

@SergioGasquez SergioGasquez merged commit be1cab5 into esp-rs:main Apr 21, 2023
@SergioGasquez SergioGasquez deleted the fix/generate-version branch April 21, 2023 09:24
@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 21, 2023

LGTM

I totally agree we should use a sane recent version - this version is more than a half year old so we can safely require it 👍

Oh, just realized my math skills are weak - it's not more than half a year from December to April ... anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update minimum supported cargo-generate version
2 participants