-
Notifications
You must be signed in to change notification settings - Fork 29
Add cargo-outdated check #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there a way to just warn on outdated deps? Another thing I've been thinking about is dependabot or equivalent to generate the PRs for us for simple bumps, but I haven't looked too much into it. |
I think it does. It allows configuring the exit-code so we could succeed even if some dependencies are not up to date. This could also be a great option but it would require us to see the output of the action
I'm using dependabot in |
Gotcha, seems like github actions don't support something like gitlabs I like the idea of this, but you're right that we might find ourselves in a situation where CI is broken for a while because we haven't/can't upgrade to a new dep somewhere. |
Thanks for the PR, sorry but I don't want random CI errors every time a package is published, that sounds really frustrating. If it's just a warning I guess that's acceptable, though I'm not sure of the utility of it at that point given they'll likely just be ignored and forgotten. |
I've added If you think this still won't be useful as we would ignore them, I can try to keep a branch in my fork that does weekly checks (sort of like a custom dependabot) |
As discussed in the last community meeting, I think warnings will likely just get ignored by most contributors (myself included, realistically). |
Add a cargo-outdated check that can help us maintain the dependencies up to date.
Maybe this is not something we want, as sometimes we may not want to update some dependencies and it would result in a CI failure until its updated, let me know your thoughts and I am happy to close the PR if agreed