-
Notifications
You must be signed in to change notification settings - Fork 21
Update esp-wifi and esp-hal #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can reproduce the
With 1.68 it works however. Given the PC is in IRAM I suspect something increased stack usage (plus maybe 1.69 and 1.70 reserve more stack somehow) Not sure if this is caused by esp-hal or esp-wifi (probably it's esp-wifi). I had a look at the diff but there is nothing really obvious wasting stack. Also esp-rs/esp-wifi-sys#196 suggests it's not an Xtensa-only thing. However, I cannot reproduce it with the example here for ESP32-C3 |
Update: Most probably not a problem with the stack BUT a linker script problem
|
I can confirm it's a linker script issue. Needs some more testing and then I can hopefully create a PR for |
I've added the examples for esp32 and esp32c3. I haven't tested if they run, as I don't have those chips on hand, but I've tested for esp32s3 and everything works fine, except for |
The problem on ESP32-S3 should be fixed in esp-rs/esp-hal#616 - maybe you want to check it by patching the dependency |
Seems like it's working for all the targets now with a patched HAL. We plan to have new HAL releases soon (and update esp-wifi as soon as the HALs are released) |
Great! Thanks for taking care of it. |
Needs testing on This gives me errors when I compile without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Compiles fine now for ESP32-C3. I had some problems with the ESP32-C3 I will merge this anyways to not block you from making progress in #9 |
Update
esp-wifi
andesp-hal
to the latest version.I've currently only done esp32s3, because it's the only chip that I have on hand.
I'm getting multiple crashes, for many different reasons, like illegal instructions, or index out of bounds.. I'm also getting this kind of error on another project using this library, so it feels like it's specific to esp-wifi and / or esp-mbedtls. I can't figure this one out.
Tested on both
1.69.0
and1.70.0
.