This repository was archived by the owner on May 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was thankfully a pretty straight-forward process, but there are some rough edges in this PR I'd like to point out:
esp-backtrace
andesp-println
to[dependencies]
, as we're not able to feature-gate dev dependencies..cargo/config.toml
when switching chip, I've just generated empty linker scripts for two of the three files on the H2; this is a little hacky, so I'm open to suggestions for better solutions, but it does work.I've tested all combination of examples/chips with success:
receive_all_frames
receive_frame
send_broadcast_frame
send_frame
I did have some strange issues while testing, which ultimately resolved themselves, so it wouldn't hurt to do another round.
As I've already mentioned to you, once this PR is merged I'll have a follow-up doing some refactoring/cleanup.