Skip to content

Remove unnecessary riscv::interrupt::enable() from examples #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 14, 2023

Fixes #924

Additionally, the debug_assist example (for RISC-V chips) doesn't use magic hardcoded numbers anymore.

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Nov 14, 2023
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this :)

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jessebraham
Copy link
Member

CI seems to be stuck on a couple PRs right now for some reason; this is all green except one job, so I'm just gonna yolo-merge it 😁

@jessebraham jessebraham merged commit 52da170 into esp-rs:main Nov 14, 2023
@bjoernQ bjoernQ deleted the remove-unnecessary-interrupt-enable branch November 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove riscv::interrupt::enable() from the examples
3 participants