Async RMT #787
Merged
Async RMT #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
feature/async-rmt
branch
from
447b6fc to
a147f43
Compare
MabezDev
approved these changes
Sep 12, 2023
JurajSadel
approved these changes
Sep 13, 2023
|
Thanks for the reviews! I will create a separate issue to align on the MSRV and merge this as is |
Closed
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Sep 22, 2023
* Async RMT * Add CHANGELOG item * Pin toml_edit transitive dependency
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Async RMT * Add CHANGELOG item * Pin toml_edit transitive dependency
tschundler
added a commit
to tschundler/esp-hal
that referenced
this pull request
Jul 13, 2024
Trying to address the 64 symbol limit in esp-rs#1779. Having troubles, I tried disabling the interrupts so it just polls the device, but the transmission never actually starts until I reset the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds async support for RMT. For now, it doesn't support wrap-mode - if we want that we should add that in a separate PR
It also fixes general RMT-RX (was broken after some refactorings)
It was necessary to pin
toml_edit(transitive dependency) because they bumped their MSRV in 0.19.15Once we agree on 1.66.0 as the MSRV we can unpin / remove the dependency