Macro to load LP core code #779
Conversation
bjoernQ
force-pushed
the
esp32c6-lp-macros
branch
from
c677685 to
07e91d4
Compare
|
No idea what the problem with the checkout action is about. |
|
Would you mind explaining the changes to the CI workflow? I don't quite follow. If we are changing the MSRV back for whatever reason, could you please update the I'm also not super excited about checking binaries in, if we're just doing that for CI then I'd rather just build it in CI I think. |
I think the idea is that |
|
Ahh gotcha, I didn't really find much in an initial search for that variable. Thanks! |
|
Thanks for the review! Any objections or does someone want more time to look into this? Otherwise, I guess I'll rebase and merge it end of today or tomorrow morning Naming of |
|
I really would prefer not to have binaries checked into git if at all possible, as I previously mentioned. Other than that I think it looks okay, haven't dug into it in too much detail. |
|
I can make sure to build the LP examples in the same job before building the HP examples. Will try that |
bjoernQ
force-pushed
the
esp32c6-lp-macros
branch
from
7b45dca to
51ec15c
Compare
|
Not having the binary checked in makes the CI builds a bit more complicated (but not too much) and needs the user to follow the instructions in the example. But not a big deal |
* Macro to load LP core code * Fix imports, add CHANGELOG.md entry * Avoid code warning * Omit path from function signature * More error checking * Clippy fix * Include the ELF used by the lp_core_basic example * Make object dependency optional * Use 1.65 for RISCV MSRV check * Use RUSTC_BOOTSTRAP for RISCV MSRV check * Remove the pre-compiled LP core example * Pin toml_edit in esp32c6-lp-hal-procmacro
* Macro to load LP core code * Fix imports, add CHANGELOG.md entry * Avoid code warning * Omit path from function signature * More error checking * Clippy fix * Include the ELF used by the lp_core_basic example * Make object dependency optional * Use 1.65 for RISCV MSRV check * Use RUSTC_BOOTSTRAP for RISCV MSRV check * Remove the pre-compiled LP core example * Pin toml_edit in esp32c6-lp-hal-procmacro
* Macro to load LP core code * Fix imports, add CHANGELOG.md entry * Avoid code warning * Omit path from function signature * More error checking * Clippy fix * Include the ELF used by the lp_core_basic example * Make object dependency optional * Use 1.65 for RISCV MSRV check * Use RUSTC_BOOTSTRAP for RISCV MSRV check * Remove the pre-compiled LP core example * Pin toml_edit in esp32c6-lp-hal-procmacro
This adds a macro for ESP32-C6 LP core to take configured pins.
On the HP core side there is a macro to load that code into LP ram and execute it.
Most probably the error handling should get improved