Actually enforce clippy lints in CI #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Actually enforce clippy lints in CI * Fix a couple clippy lints in `esp-riscv-rt` * Fix a couple clippy lints for `esp32c6-lp-hal`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were disabled exactly one year ago to the day (funny coincidence that I'm just fixing it now 😅 ).
I think the project has progressed enough that we can re-enable these, IIRC a large part of the pain was with adding new chips, and this process has been significantly streamlined over the last year.
Additionally fixed a couple lint errors in
esp-riscv-rtandesp32c6-lp-halto get CI green again. I'd added one lint as an exception foresp32c6-lp-halfor the time being.