Skip to content

If the embassy feature is enabled, ensure that a time driver implementation is available #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jessebraham
Copy link
Member

Closes #564

@jessebraham jessebraham requested a review from MabezDev June 21, 2023 12:19
@jessebraham jessebraham added the skip-changelog No changelog modification needed label Jun 21, 2023
@jessebraham
Copy link
Member Author

(Forgot to add the label when I opened the PR so the Changelog job will never pass here)

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit b346d8b into esp-rs:main Jun 21, 2023
@jessebraham jessebraham deleted the fixes/build-script branch June 21, 2023 13:40
MabezDev pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with cfg dependency features (probably esp32-hal -> esp-hal-common)
2 participants