Skip to content

Use T::clone_unchecked instead of self to avoid infinite recursion #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

Use T::clone_unchecked instead of self to avoid infinite recursion #427

merged 1 commit into from
Mar 8, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Mar 8, 2023

Not sure how I missed this warning before, but also feels like infinite recursion should probably be an error...

bjoernQ
bjoernQ approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessebraham
jessebraham approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jessebraham jessebraham merged commit c01317e into esp-rs:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MabezDev @jessebraham @bjoernQ