-
Notifications
You must be signed in to change notification settings - Fork 313
Update README
s, housekeeping
#1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
7ce9e83
to
b04f3d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think its a good improvement and I agree on trying to keep the readmes simple and defer to other places when possible.
|
||
Most traits defined by the [embedded-hal] family of packages are implemented as applicable. | ||
For help getting started with this HAL, please refer to [The Rust on ESP Book] and the [documentation]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also include a link here to the no_std training as getting started guide? https://docs.esp-rs.org/no_std-training/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly, I am not quite sure how much detail to go into. I think the book probably mentions the training? But I'm also not against adding it, again just trying to find a good balance here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This happens to me randomly, refreshing usually fixes it. Been happening for a long time, not sure why only that badge does it. There has to be some rate-limiting going on... somewhere, or something 😅 |
* Remove patches and just use git dependency for PACs instead * Various `README.md` normalization/updates for simpler packages * Update `README.md` for `esp-hal` and `esp-lp-hal` * Update repo-level `README.md`
A few mostly unrelated things going on here:
README.md
files:Possibly controversial (can revert this one if needed): added a minimal.vscode/settings.json
just to deal with the annoying TOML formatting issuesgit update-index --skip-worktree .vscode/settings.json
will ignore any subsequent changes to this file, so people can modify it as needed without the changes being trackedStill kind of annoying to deal with, don't think we can do anything at the git repo levelI would like to try and keep the READMEs minimal I think, just because things tend to fall out of sync. If there's anything else anybody thinks is worth mentioning please let me know, I have no problem updating this further. However, as I stated, I think we should try to defer to the book and documentation whenever possible.