Skip to content

Update READMEs, housekeeping #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Mar 22, 2024

A few mostly unrelated things going on here:

  • There were some crates.io patches which had snuck in (I think we should try to avoid these moving forward, but that's probably another conversation), so I have removed these and just replaced them with git dependencies
  • I have updated the various README.md files:
    • Updated/normalized the badges
    • Simplified the READMEs as much as possible, defer to the book and documentation (which will need improving now 😉 ) wherever possible
  • Possibly controversial (can revert this one if needed): added a minimal .vscode/settings.json just to deal with the annoying TOML formatting issues
    • git update-index --skip-worktree .vscode/settings.json will ignore any subsequent changes to this file, so people can modify it as needed without the changes being tracked
    • Still kind of annoying to deal with, don't think we can do anything at the git repo level
    • Never mind, this is super annoying to deal with already.

I would like to try and keep the READMEs minimal I think, just because things tend to fall out of sync. If there's anything else anybody thinks is worth mentioning please let me know, I have no problem updating this further. However, as I stated, I think we should try to defer to the book and documentation whenever possible.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Mar 22, 2024
@jessebraham
Copy link
Member Author

jessebraham commented Mar 22, 2024

Hmm something weird going on with the PACs after updating the commit hash, will investigate

@jessebraham jessebraham force-pushed the fixes/housekeeping branch 2 times, most recently from 7ce9e83 to b04f3d0 Compare March 22, 2024 14:16
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think its a good improvement and I agree on trying to keep the readmes simple and defer to other places when possible.


Most traits defined by the [embedded-hal] family of packages are implemented as applicable.
For help getting started with this HAL, please refer to [The Rust on ESP Book] and the [documentation].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include a link here to the no_std training as getting started guide? https://docs.esp-rs.org/no_std-training/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, I am not quite sure how much detail to go into. I think the book probably mentions the training? But I'm also not against adding it, again just trying to find a good balance here.

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 22, 2024

It shows this for all READMEs except the one in the root:

image

Maybe that's normal ... I have no idea how those badges work in detail

@SergioGasquez
Copy link
Member

Maybe that's normal ... I have no idea how those badges work in detail

image

Works for me, although I've seen similar issues where it shows a werid messages

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jessebraham
Copy link
Member Author

Maybe that's normal ... I have no idea how those badges work in detail

This happens to me randomly, refreshing usually fixes it. Been happening for a long time, not sure why only that badge does it. There has to be some rate-limiting going on... somewhere, or something 😅

@jessebraham jessebraham added this pull request to the merge queue Mar 22, 2024
Merged via the queue into esp-rs:main with commit 8da8425 Mar 22, 2024
@jessebraham jessebraham deleted the fixes/housekeeping branch March 22, 2024 17:30
yanshay pushed a commit to yanshay/esp-hal that referenced this pull request Mar 25, 2024
* Remove patches and just use git dependency for PACs instead

* Various `README.md` normalization/updates for simpler packages

* Update `README.md` for `esp-hal` and `esp-lp-hal`

* Update repo-level `README.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants