Skip to content

Add TimerWakeupSource for the esp32-c6 deepsleep. #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

t-moe
Copy link
Contributor

@t-moe t-moe commented Feb 26, 2024

This PR adds support for deepsleep-wakeup by timer on the esp32c6

@t-moe t-moe force-pushed the timerwakeup branch 5 times, most recently from 7bd2966 to 14c0154 Compare February 26, 2024 09:10
@bjoernQ
Copy link
Contributor

bjoernQ commented Feb 27, 2024

That's a very useful addition. I guess we should get #1196 in, but from a brief look the code looks good to me

@t-moe
Copy link
Contributor Author

t-moe commented Feb 27, 2024

No worries, I can rebase afterwards ^^.

EDIT: Rebased. Ready for review.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me, thanks for this! Very nice to have.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in my tests, too! Thanks

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@jessebraham jessebraham added this pull request to the merge queue Feb 28, 2024
Merged via the queue into esp-rs:main with commit 0c99d8b Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants