-
Notifications
You must be signed in to change notification settings - Fork 292
C6: LP_I2C basic driver #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C6: LP_I2C basic driver #1185
Conversation
I also tested on HW - apparently it works. Given the example is not too exciting maybe adding a note that users should use a logic-analyzer or scope to actually see something would be a good thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding this correctly that we are copy and pasting the lp driver into esp-hal, once its complete in esp-lp-hal?
Is there any reason we aren't depending on esp-lp-hal in esp-hal and re-exporting the driver there for the HP to use? I guess the pacs have different base addresses.
I will create an issue to fix this at some point, but I'm happy to merge this as is for now.
Thanks @JurajSadel and @playfulFence for working on this and bringing it over the finish line!
ba80229
to
e53145c
Compare
Yeah this looks kind of strange, I don't really understand why we're duplicating so much code. This probably needs some refactoring. |
Merging this so it won't start to rot until we are sure, how to proceed. |
Thanks for reviews! |
Or not... |
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have
CC @playfulFence