Skip to content

C6: LP_I2C basic driver #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 21, 2024
Merged

C6: LP_I2C basic driver #1185

merged 14 commits into from
Feb 21, 2024

Conversation

JurajSadel
Copy link
Contributor

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

CC @playfulFence

@bjoernQ
Copy link
Contributor

bjoernQ commented Feb 20, 2024

I also tested on HW - apparently it works.

Given the example is not too exciting maybe adding a note that users should use a logic-analyzer or scope to actually see something would be a good thing?

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding this correctly that we are copy and pasting the lp driver into esp-hal, once its complete in esp-lp-hal?

Is there any reason we aren't depending on esp-lp-hal in esp-hal and re-exporting the driver there for the HP to use? I guess the pacs have different base addresses.

I will create an issue to fix this at some point, but I'm happy to merge this as is for now.

Thanks @JurajSadel and @playfulFence for working on this and bringing it over the finish line!

@jessebraham
Copy link
Member

Am I understanding this correctly that we are copy and pasting the lp driver into esp-hal, once its complete in esp-lp-hal?

Yeah this looks kind of strange, I don't really understand why we're duplicating so much code. This probably needs some refactoring.

@JurajSadel
Copy link
Contributor Author

Merging this so it won't start to rot until we are sure, how to proceed.

@JurajSadel JurajSadel added this pull request to the merge queue Feb 21, 2024
Merged via the queue into esp-rs:main with commit 9378639 Feb 21, 2024
@JurajSadel
Copy link
Contributor Author

Thanks for reviews!

@jessebraham
Copy link
Member

Am I understanding this correctly that we are copy and pasting the lp driver into esp-hal, once its complete in esp-lp-hal?

Yeah this looks kind of strange, I don't really understand why we're duplicating so much code. This probably needs some refactoring.

Or not...

@JurajSadel JurajSadel deleted the feat/lp-i2c branch April 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants