Skip to content

Clean up example imports #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2023
Merged

Clean up example imports #1027

merged 2 commits into from
Dec 14, 2023

Conversation

jessebraham
Copy link
Member

Just fixing a few small issues I happened to notice:

  1. We were importing from esp-hal-common in some examples; this is not necessary and I don't want to encourage this.
  2. We were aliasing the HAL packages in some examples; again, not necessary.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Dec 14, 2023
bjoernQ
bjoernQ approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would be good if VSCode would let us configure the auto-import preferences ... I really don't like seeing esp_hal_common used in imports but I think it's the first suggestion usually

@jessebraham jessebraham added this pull request to the merge queue Dec 14, 2023
Merged via the queue into esp-rs:main with commit 82c579e Dec 14, 2023
@jessebraham jessebraham deleted the fixes/examples branch December 14, 2023 15:59
Volkalex28 pushed a commit to Volkalex28/esp-hal that referenced this pull request Feb 6, 2024
@jessebraham @Volkalex28
Clean up example imports (esp-rs#1027)
caecf91 
* Don't import directly from `esp-hal-common` in examples

* Do no alias the HAL packages in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessebraham @bjoernQ