Allow for splitting of the USB Serial JTAG peripheral into tx/rx components #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Dec 14, 2023
|
(Distracted with other things right now, will wrap this up next week) |
|
My example isn't working and I probably won't get to this for awhile, so closing the PR for now. If anybody else is interested in carrying on work please feel free to do so, otherwise I'll get back to it when I get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs more testing, and I plan to update the
embassy_usb_serial_jtagexamples to use reader/writer tasks like the UART examples do, so leaving as draft for now. However, the actual changes to the driver shouldn't change I don't think, so can get some eyes on that for now.Closes #1006