Remove label #181
Merged
Remove label #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI fix is already done in #178 |
|
Since you were the one adding the label then resolving my comment without explaining why (https://github.com/esp-rs/esp-generate/pull/159/files#r2031312571), what was the point of the label and:
|
|
To be honest, I dont remember if I added the label (I dont think I have), nor resolving your comment, sorry. I should have been more careful before merging it. |
SergioGasquez
force-pushed
the
fix/ci-nightly
branch
from
42f62c5 to
b2ef454
Compare
bugadani
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was making the CI fail. eg: https://github.com/esp-rs/esp-generate/actions/runs/15233805381/job/42845015708