Skip to content

Conversation

@mailiam
Copy link
Contributor

@mailiam mailiam commented Apr 5, 2025

Update the embedded-io and embedded-io-async dependencies to utilize the defmt-03 instead of unreachable defmt

Please refer to the document

mailiam pushed a commit to mailiam/esp-generate that referenced this pull request Apr 5, 2025
@mailiam mailiam force-pushed the fix/embedded-io-defmt branch from 22bd87c to 4fd487f Compare April 5, 2025 15:07
@mailiam mailiam force-pushed the fix/embedded-io-defmt branch from 4fd487f to 7ffd434 Compare April 5, 2025 15:12
@bugadani
Copy link
Contributor

bugadani commented Apr 5, 2025

Good spot, maybe we should make the CI make more noise (https://github.com/esp-rs/esp-generate/actions/runs/14257287711/job/39962175475)

@mailiam
Copy link
Contributor Author

mailiam commented Apr 5, 2025

Good spot, maybe we should make the CI make more noise (https://github.com/esp-rs/esp-generate/actions/runs/14257287711/job/39962175475)

Haha CI was working correctly 😁

Here's GitHub doc about scheduled action notification:

Notifications for scheduled workflows are sent to the user who initially created the workflow. If a different user updates the cron syntax in the workflow file, subsequent notifications will be sent to that user instead. If a scheduled workflow is disabled and then re-enabled, notifications will be sent to the user who re-enabled the workflow rather than the user who last modified the cron syntax.

Or perhaps build status on README.md?

Or something like creating issue when scheduled build fails?

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

I just opened #158 where we will improve the CI situation

@SergioGasquez SergioGasquez added this pull request to the merge queue Apr 7, 2025
Merged via the queue into esp-rs:main with commit f0b83ee Apr 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants