s_i2c_synchronous_transaction(924): I2C transaction failed

[trombik]

I tried moving the code from the old library to the new repository. Everything was moved successfully, but I received strange errors.

E (1773) i2c: i2c_set_timeout(954): i2c timing value error
E (1773) ags10: Failed to send read command: ESP_ERR_INVALID_ARG
E (1773) ags10_basic_example: Failed to read AGS10 version: ESP_FAIL

After that, I decided to try running another library that had already been moved. For example, I chose the QMI8658C library. First, I encountered errors when attempting to build the project. Because of managed_components/esp-idf-lib__esp_idf_lib_helpers/common/cmake/esp-idf-lib.cmake. I could fix that by adding

get_target_property(COMPONENT_TYPE ${COMPONENT_LIB} TYPE)
if(NOT COMPONENT_TYPE STREQUAL "INTERFACE_LIBRARY")

endif() 

around

 target_compile_options(${COMPONENT_LIB} PRIVATE
        ${ESP_IDF_LIB_FLAGS}
        ${ESP_IDF_LIB_CI_FLAGS}
    )

But even after successfully build I got a bunch of different errors

I (245) i2cdev: [Port 0] Successfully installed I2C master bus (Handle: 0x408128ec).
I (255) i2cdev: [0x6b at 0] Device added successfully (Device Handle: 0x40812da8, Speed: 400000 Hz).
I (265) main_task: Returned from app_main()
E (1265) i2c.master: s_i2c_synchronous_transaction(924): I2C transaction failed
E (1265) i2c.master: i2c_master_multi_buffer_transmit(1186): I2C transaction failed
W (1265) i2cdev: [0x6b at 0] I2C op failed (Try 0, Handle 0x40812da8): 259 (ESP_ERR_INVALID_STATE).
W (1275) i2cdev: [0x6b at 0] Invalid state error - handle may need recreation
W (1275) i2cdev: [0x6b at 0] Removing potentially corrupted device handle 0x40812da8 after permanent error
W (1325) i2cdev: [0x6b at 0] Retrying operation...
I (1325) i2cdev: [0x6b at 0] Device added successfully (Device Handle: 0x4080fce4, Speed: 400000 Hz).
E (2325) i2c.master: s_i2c_synchronous_transaction(924): I2C transaction failed
E (2325) i2c.master: i2c_master_multi_buffer_transmit(1186): I2C transaction failed
W (2325) i2cdev: [0x6b at 0] I2C op failed (Try 1, Handle 0x4080fce4): 259 (ESP_ERR_INVALID_STATE).
W (2335) i2cdev: [0x6b at 0] Invalid state error - handle may need recreation
W (2335) i2cdev: [0x6b at 0] Removing potentially corrupted device handle 0x4080fce4 after permanent error
W (2425) i2cdev: [0x6b at 0] Retrying operation...

As I understand it, it starts using another i2cdev library. For now, I can't get either of those libraries to work. I will try to understand and fix it, but I'm not sure when I'll have the time for such an investigation.

Originally posted by @xyzroe in esp-idf-lib/ags10#2 (comment)

[trombik]

@xyzroe

which esp-idf version are you using?

[trombik]

Looks like i2c_master issue.

https://github.com/espressif/esp-idf/issues?q=is%3Aissue%20state%3Aopen%20s_i2c_synchronous_transaction

If my guess is correct, switching to legacy i2c.h should solve the issue.

@xyzroe Would you try Use Legacy I2C Driver API?

Menu path: (Top) -> Component config -> I2C Device Library -> Use Legacy I2C Driver API

[trombik]

E (1773) i2c: i2c_set_timeout(954): i2c timing value error

from this one, it looks like you are using i2c_legacy.

the error happens because, it seems, I2CDEV_MAX_STRETCH_TIME is incorrect. this should be I2C_LL_MAX_TIMEOUT, but it is defined in hal/i2c_ll.h and when hal/i2c_ll.h is included, that header also defines a conflicting struct, i2c_dev_t, a name collision.

[trombik]

would you try the following?

• choose correct I2C_LL_MAX_TIMEOUT below
• define I2CDEV_MAX_STRETCH_TIME with the value in i2cdev.h

components/hal/esp32c2/include/hal/i2c_ll.h
784:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE

components/hal/esp32/include/hal/i2c_ll.h
854:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_REG_V

components/hal/esp32c3/include/hal/i2c_ll.h
961:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_REG_V

components/hal/esp32s2/include/hal/i2c_ll.h
902:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_REG_V

components/hal/esp32s3/include/hal/i2c_ll.h
965:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE_V

components/hal/esp32h2/include/hal/i2c_ll.h
911:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE

components/hal/esp32c5/include/hal/i2c_ll.h
895:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE

components/hal/esp32c6/include/hal/i2c_ll.h
1004:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE

components/hal/esp32p4/include/hal/i2c_ll.h
1008:#define I2C_LL_MAX_TIMEOUT I2C_TIME_OUT_VALUE

i2cdev/i2cdev.h

Lines 69 to 76 in abf0ebc

	#include <soc/i2c_reg.h> // For I2C_TIME_OUT_VALUE_V, etc.
	#if defined(I2C_TIME_OUT_VALUE_V)
	#define I2CDEV_MAX_STRETCH_TIME I2C_TIME_OUT_VALUE_V
	#elif defined(I2C_TIME_OUT_REG_V)
	#define I2CDEV_MAX_STRETCH_TIME I2C_TIME_OUT_REG_V
	#else
	#define I2CDEV_MAX_STRETCH_TIME 0x00ffffff
	#endif

[trombik]

@quinkq

Would you take a look?

[xyzroe]

Of course, I'll try. A little bit later.

[quinkq]

Hi @trombik @xyzroe I've looked at the AGS10 driver and found the that likely cause of your CI failures is that AGS10 implementation mixes two incompatible I2C driver approaches, which causes the s_i2c_synchronous_transaction(924): I2C transaction failed errors.

ags10.c uses both the old ESP-IDF I2C driver AND the i2cdev abstraction:

WRONG direct ESP-IDF legacy calls in ags10_set_i2c_address():

#include <driver/i2c.h>  // This shouldn't be here

i2c_cmd_handle_t cmd = i2c_cmd_link_create();
i2c_master_start(cmd);
i2c_master_write_byte(cmd, (dev->addr << 1) | I2C_MASTER_WRITE, true);
esp_err_t err = i2c_master_cmd_begin(dev->port, cmd, 1000 / portTICK_PERIOD_MS);

While using correct i2cdev abstraction in _read_reg():

I2C_DEV_TAKE_MUTEX(dev);
esp_err_t err = i2c_dev_write(dev, NULL, 0, &cmd, 1);
I2C_DEV_GIVE_MUTEX(dev);

This creates hardware resource conflicts because both the modern i2cdev and legacy ESP-IDF driver try to control the same I2C device.

You need to delete #include <driver/i2c.h> and rewrite ags10_set_i2c_address() and ags10_set_zero_point_with() to use i2cdev functions (based on ina219):

esp_err_t ags10_set_i2c_address(i2c_dev_t *dev, uint8_t new_address)
{
    CHECK_ARG(dev);
    
    uint8_t buf[6];
    new_address &= 0x7F;
    buf[0] = AGS10_SETADDR_REG;
    buf[3] = buf[1] = new_address;
    buf[4] = buf[2] = ~new_address;
    buf[5] = crc8(buf + 1, 4);
    
    I2C_DEV_TAKE_MUTEX(dev);
    I2C_DEV_CHECK(dev, i2c_dev_write(dev, NULL, 0, buf, 6));
    I2C_DEV_GIVE_MUTEX(dev);
    
    dev->addr = new_address;
    return ESP_OK;
}

I recommend checking other sensors in this library - all use I2C_DEV_TAKE_MUTEX(), i2c_dev_write()/i2c_dev_read(), and I2C_DEV_GIVE_MUTEX(). No direct ESP-IDF I2C calls. The i2cdev abstraction handles all the complexity, by bypassing it, you're going to be creating the exact conflicts.