Skip to content

feat(gfps): Switch to using esp-cpp/nearby (fork of google/nearby) #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

finger563
Copy link
Contributor

Description

  • Switch submodule google/nearby to be esp-cpp/nearby at tag espp-v1.0.12 which is the same commit we were at in google/nearby

Motivation and Context

Related to #466, we need some additional events / callbacks to fully support subsequent pairing.
This will allow us to more easily add changes to the nearby library and integrate them with our systems.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

✅Static analysis result - no issues found! ✅

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the Google Fast Pair Service (GFPS) submodule from the original google/nearby repository to a fork maintained by esp-cpp/nearby. The change maintains the same commit history while enabling the team to add custom modifications for better ESP-IDF integration and support for subsequent pairing functionality.

  • Replaces the google/nearby submodule with esp-cpp/nearby fork
  • Updates submodule URL while maintaining existing path structure

@finger563 finger563 merged commit 410a26a into main Jul 10, 2025
4 of 6 checks passed
@finger563 finger563 deleted the feat/esp-cpp-nearby branch July 10, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant