Select Timeout when not in TEST_RUNNING State #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
davidBar-On
force-pushed
the
issue-1735-timeout-select-when-not-in-running-state
branch
from
e5364f9 to
71b1ae9
Compare
davidBar-On
force-pushed
the
issue-1735-timeout-select-when-not-in-running-state
branch
from
71b1ae9 to
45e7019
Compare
davidBar-On
force-pushed
the
issue-1735-timeout-select-when-not-in-running-state
branch
from
45e7019 to
0010924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): The iperf3 server hangs while printing the report #1735
Brief description of code changes (suitable for use as a commit message):
Timeout
select()when the process is not inTEST_RUNNINGstate, using the--rcv-timeoutvalue as the timeout. In #1753 for example, the server hanged forever because it waited to the "IPERF_DONE" that never arrived. Per @RizziMau comment after testing the change, this PR is solves the problem.