Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in an error condition. #1333

Merged
merged 1 commit into from
May 12, 2022
Merged

Fix memory leak in an error condition. #1333

merged 1 commit into from
May 12, 2022

Conversation

bmah888
Copy link
Contributor

@bmah888 bmah888 commented May 10, 2022

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): memory leak for test->settings #1332

  • Brief description of code changes (suitable for use as a commit message):

Fix memory leav in an error condition. We weren't free()-ing test->settings when we bailed out in a certain error state.

We weren't free()-ing test->settings when we bailed out in a
certain error state.

Fixes #1332.
@bmah888 bmah888 requested a review from swlars May 10, 2022 00:48
@bmah888 bmah888 self-assigned this May 10, 2022
@bmah888 bmah888 added the bug label May 10, 2022
@bmah888 bmah888 linked an issue May 10, 2022 that may be closed by this pull request
Copy link
Contributor

@swlars swlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bmah888 bmah888 merged commit 0208757 into master May 12, 2022
@bmah888 bmah888 deleted the issue-1332 branch May 13, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory leak for test->settings
2 participants