Merge "End to end tests" branch including react test harness and end-to-end playwright harness #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkafader-esnet
commented
Nov 8, 2024
| // this appears to be a "load-bearing" reassignment... removing it causes tests to fail? | ||
| var topo = newTopology; | ||
| /*expect(function(){ | ||
| /*expect(function(){ |
There was a problem hiding this comment.
Should this commented code be removed?
- added compileOnSave flag to tsconfig - corrected imports for GrafanaTheme2 and locationService from @grafana packages @grafana/data and @grafana/runtime/services/LocationService - exported MapPanelProps from MapPanel - exported MapPanel - removed wrapping calls of withTheme HOC out of MapPanel
- added testables code into dist
…workmap-panel into end-to-end-tests
- restored import of locationServices from @grafana/runtme
jkafader-esnet
commented
Nov 12, 2024
- restored import of StringFieldConfigSettings out of @grafana/data instead of deeper introspective import source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.