Fix entry point conflict with actually exist file #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ije
reviewed
Mar 16, 2023
| @@ -42,7 +42,17 @@ func (task *BuildTask) ID() string { | |||
|
|
|||
| if pkg.Submodule != "" { | |||
| name = pkg.Submodule | |||
| } else { | |||
| pack, _ := fetchPackageInfo(pkg.Name, pkg.Version) | |||
There was a problem hiding this comment.
pls handle the error in casepackis nil.- consider the "." of
exports
There was a problem hiding this comment.
Sure, Will fix these cases tomorrow
Fixing pack is nil is difficult in the ID method coz the method is called in many places.
I think can refactor the logic of the build later.
ije
reviewed
Mar 16, 2023
Yup, Do you want to follow up the CSS file path with the entry path? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #547