Skip to content

Upgrade to Angular 17#446

Open
StevenKolamkuzhiyil wants to merge 7 commits intoesm-bundle:mainfrom
StevenKolamkuzhiyil:main
Open

Upgrade to Angular 17#446
StevenKolamkuzhiyil wants to merge 7 commits intoesm-bundle:mainfrom
StevenKolamkuzhiyil:main

Conversation

@StevenKolamkuzhiyil
Copy link

@StevenKolamkuzhiyil StevenKolamkuzhiyil commented Jan 20, 2024

Upgrade to Angular 17:

  • upgrade Angular dependencies to 17.3.4
  • update rollup version and replace deprecated rollup-plugin-terser with @rollup/plugin-terser
  • use ES2022
  • safe-check if ngDevMode exists in @angular/router in order to fix ngDevMode is not defined error

@phungthithu
Copy link

Hello, are you upgrade angular 17 done???
I have the error ngdevMode not defind 🥲

@StevenKolamkuzhiyil StevenKolamkuzhiyil marked this pull request as ready for review July 23, 2024 21:22
@StevenKolamkuzhiyil
Copy link
Author

Hello, are you upgrade angular 17 done??? I have the error ngdevMode not defind 🥲

Hello @phungthithu, does the error persist with the updated version (17.3.4)? In the previous version (17.1.0) I received the same error which was why I added the patch-package script. In the current version I couldn't reproduce this error so I removed the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants