Skip to content

Commit

Permalink
Use he_offline_deployment if explicitly set
Browse files Browse the repository at this point in the history
- Use he_offline_deployment parameter if explicitly set
- Use only ovirt_engine_setup_offline parameter for update packages
- Change the default value of ovirt_engine_setup_offline to false in order to
  update packages
- Remove ovirt_engine_setup_update_all_packages parameter
- Update README

Bug-Url: https://bugzilla.redhat.com/1816619
Signed-off-by: Asaf Rachmani <arachman@redhat.com>
  • Loading branch information
arachmani committed Apr 5, 2020
1 parent 1c55b74 commit 4a62d49
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ No.
| he_tcp_t_address | null | hostname to connect if he_network_test is *tcp* |
| he_tcp_t_port | null | port to connect if he_network_test is *tcp* |
| he_pause_host | false | Pause the execution to let the user interactively fix host configuration |
| he_offline_deployment | false | If `True`, updates for all packages will be disabled |

## NFS / Gluster Variables

Expand Down
1 change: 1 addition & 0 deletions defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ he_tcp_t_port: null
# ovirt-hosted-engine-setup variables
he_just_collect_network_interfaces: false
he_libvirt_authfile: '/etc/ovirt-hosted-engine/virsh_auth.conf'
he_offline_deployment: false

# *** Do Not Use On Production Environment ***
# ********** Used for testing ONLY ***********
Expand Down
3 changes: 1 addition & 2 deletions tasks/full_execution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
ovirt_engine_setup_firewall_manager: null
ovirt_engine_setup_answer_file_path: /root/ovirt-engine-answers
ovirt_engine_setup_use_remote_answer_file: true
ovirt_engine_setup_update_all_packages: false
ovirt_engine_setup_offline: true
ovirt_engine_setup_offline: "{{ he_offline_deployment }}"
ovirt_engine_setup_admin_password: "{{ he_admin_password }}"
import_role:
name: ovirt.engine-setup
Expand Down
3 changes: 1 addition & 2 deletions tasks/partial_execution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@
ovirt_engine_setup_firewall_manager: null
ovirt_engine_setup_answer_file_path: /root/ovirt-engine-answers
ovirt_engine_setup_use_remote_answer_file: true
ovirt_engine_setup_update_all_packages: false
ovirt_engine_setup_offline: true
ovirt_engine_setup_offline: "{{ he_offline_deployment }}"
ovirt_engine_setup_admin_password: "{{ he_admin_password }}"
import_role:
name: ovirt.engine-setup
Expand Down

0 comments on commit 4a62d49

Please sign in to comment.