Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip add plugin when already imported #70

Merged

Conversation

syi0808
Copy link
Contributor

@syi0808 syi0808 commented Jun 25, 2024

Prerequisites checklist

What is the purpose of this pull request?

prevent syntax error which threw by duplicate import fixupPluginRules because of multiple compat needs plugins.

What changes did you make? (Give an overview)

  • skip add fixupPluginRules when already pushed in bindings

Related Issues

fixes #72

Is there anything you'd like reviewers to focus on?

Copy link

linux-foundation-easycla bot commented Jun 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@eslint-github-bot
Copy link

Hi @syi0808!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@syi0808 syi0808 changed the title skip add plugin when already imported fix: skip add plugin when already imported Jun 25, 2024
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jun 25, 2024
@nzakas
Copy link
Member

nzakas commented Jun 25, 2024

Thanks for the contribution. We need you to fill out a bug report before we can consider this.

@syi0808
Copy link
Contributor Author

syi0808 commented Jun 26, 2024

Thanks for the contribution. We need you to fill out a bug report before we can consider this.

I fill out a bug report and connect this pr. thank you!

@nzakas
Copy link
Member

nzakas commented Jun 26, 2024

@syi0808 we also need you to sign the CLA. Please see the comment posted by the bot.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Just need the CLA signed to merge.

@syi0808
Copy link
Contributor Author

syi0808 commented Jun 26, 2024

Changes LGTM. Just need the CLA signed to merge.

I'm sorry to have made you check many times. I signed CLA now. thank you!

@nzakas
Copy link
Member

nzakas commented Jun 26, 2024

No worries. Thank you!

@nzakas nzakas merged commit 96f3e01 into eslint:main Jun 26, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributor pool
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: duplicate import fixupPluginRules
2 participants