Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tech sponsors #63

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

harish-sethuraman
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

  • add tech sponsors to readmes of all packages

Related Issues

fixes #57

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good like in eslint/eslint, but @nzakas mentioned "automatically" so I'm not sure if the goal was maybe to fetch data from https://raw.githubusercontent.com/eslint/eslint.org/main/src/_data/techsponsors.json instead of hardcoding.

@harish-sethuraman
Copy link
Member Author

My bad I also get why its better to do it similar to sponsors and not have it statically hard coded. I have made the changes here. there are some open points.

  1. How do we want the layout to look?
    • currently I have made it similar to gold sponsors. (as we were missing content related to the text. The texts in the JSON are very short)
  2. Do we want to use the images from eslint.org site? or do we want to get it from somewhere else?
    • added image from eslint.org for now

@nzakas
Copy link
Member

nzakas commented Jun 20, 2024

We can have it look the same as the bronze sponsors, which is what we do on the website (https://eslint.org/sponsors).

tools/update-readme.js Outdated Show resolved Hide resolved
tools/update-readme.js Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 7a626f6 into eslint:main Jun 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change Request: Add technology sponsors to READMEs
3 participants