Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Decision docs for start of rewrite #52

Merged
merged 6 commits into from
Jun 11, 2024
Merged

docs: Decision docs for start of rewrite #52

merged 6 commits into from
Jun 11, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 7, 2024

Prerequisites checklist

What is the purpose of this pull request?

Formally documents decisions around this repo.

What changes did you make? (Give an overview)

Added decision documents covering the following:

  • Added a template
  • To do a core rewrite
  • Using JS/JSDoc/tsc instead of TypeScript
  • Using ESM

Related Issues

Is there anything you'd like reviewers to focus on?

I did my best to piece back together the logic from our various discussions, but do let me know if any important details are missing.

@eslint-github-bot eslint-github-bot bot added the documentation Improvements or additions to documentation label Jun 7, 2024
decisions/003-esm.md Outdated Show resolved Hide resolved
Copy link
Member

@fasttime fasttime Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth linking to the original discussion somewhere for the benefit of new readers?

fasttime
fasttime previously approved these changes Jun 11, 2024
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Would like @mdjermanovic to verify.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two possible typos.

decisions/002-javascript-jsdoc-tsc.md Outdated Show resolved Hide resolved
decisions/002-javascript-jsdoc-tsc.md Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@nzakas nzakas merged commit 19a755b into main Jun 11, 2024
14 checks passed
@nzakas nzakas deleted the ts-decision branch June 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants