-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @eslint/compat package #5
Conversation
I prepared a PR to check this in action with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just not sure if it's safe to merge until we resolve #8.
Also, should we maybe do #3 (comment) in this package too? |
It's safe to merge. The CI is doing some unneeded work but nothing consequential. I'm going to go through and update all of the packages at in a separate PR. |
This adds a
@eslint/compat
package with the following functions:fixupRule()
- used to wrap rules in a compatibility layerfixupPluginRules()
- used to wrap all rules in a pluginfixupConfigRules()
- used to wrap all rules in all plugins in a config arrayView the README for more details.
closes #4