feat: Add includeIgnoreFile() method #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
reviewed
Jun 6, 2024
packages/compat/README.md
Outdated
| import { includeIgnoreFile } from "@eslint/compat"; | ||
|
|
||
| export default [ | ||
| includeIgnoreFile(".gitignore"), |
There was a problem hiding this comment.
I think it would be better to recommend passing an absolute path here. Relative paths are resolved relative to process.cwd(), so whether this will work or not depends on where eslint is run from.
There was a problem hiding this comment.
Ah right. 🤦 Second time this week I forgot that fact.
mdjermanovic
reviewed
Jun 6, 2024
mdjermanovic
reviewed
Jun 6, 2024
mdjermanovic
reviewed
Jun 7, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add a
includeIgnoreFile()function.What changes did you make? (Give an overview)
includedIgnoreFile()function that is exported from@eslint/compatconvertIgnorePatternToMinimatch()function that is exported from@eslint/compat(purposely undocumented because I'm not sure how end users would use this)@eslint/compat@eslint/migrate-configto use theconvertIgnorePatternToMinimatch()function from@eslint/compatinstead of duplicating that functionality@eslint/migrate-configcomes after@eslint/compatdue to the new dependency on itNote: The
includeIgnoreFile()function differs from the original issue in that there is no second argument. I'm not sure it's needed and it could complicate the process if the ignore file is in an ancestor directory. For this first release, I'd like to see what kind of feedback we get as-is.Related Issues
fixes #44
Is there anything you'd like reviewers to focus on?