fix: add validation for plugins in isLegacyConfig
#292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
changed the title
plugins in defineConfig
aladdin-add
changed the title
plugins in defineConfigplugins in isLegacyConfig
aladdin-add
changed the title
plugins in isLegacyConfigplugins in isLegacyConfig
9 tasks
aladdin-add
commented
Oct 10, 2025
aladdin-add
force-pushed
the
fix/flat-config-check
branch
from
180dd13 to
bd37ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
eslintrc's
pluginsmust be an array; while flat config's must be an object. this PR added the check to fix the edge case as described in the issue.What changes did you make? (Give an overview)
Related Issues
fixes: #291
refs: eslint/generator-eslint#228 (comment)
Is there anything you'd like reviewers to focus on?
n/a.