Skip to content

Conversation

Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

The repo currently mixes test filename styles: some tests end with .test.js while others don’t. In addition, packages used non‑recursive Mocha globs, which meant certain nested tests never ran — for example, the rules tests under packages/compat/tests/rules/. This PR standardizes on the .test.js suffix and uses a recursive glob so all tests are discovered and executed consistently.

What changes did you make? (Give an overview)

  • Renamed all non-suffixed test files to use the .test.js suffix
  • Updated each package’s test script to only run suffixed tests recursively

Related Issues

Is there anything you'd like reviewers to focus on?

@mdjermanovic
Copy link
Member

I'm in favor of this change 👍

@mdjermanovic
Copy link
Member

There are merge conflicts now.

@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Sep 10, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 7255100 into eslint:main Sep 10, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants