fix: relax type for rule.meta.docs.recommended #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkwaiblinger
force-pushed
the
adjust-recommended-type
branch
from
2ad531c to
0c121bc
Compare
fasttime
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Thanks for the pull request. Since we are here, can we add a unit test to packages/core/tests/types/types.test.ts to make sure that RulesMetaDocs allows a recommended property?
Also, the CI build is failing. Can you check?
Added tests 👍
Looks to be green now? But I'm not sure that the CI actually ran — looks like it needs an approval to run |
|
Looks like Prettier formatting is failing. If you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
fixes #234