-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Simplify type generation #23
Conversation
in that case why do we have
|
I'm guessing that you didn't delete |
@@ -9,7 +9,8 @@ | |||
"lint": "eslint .", | |||
"lint:fix": "eslint --fix .", | |||
"fmt": "prettier --write .", | |||
"fmt:check": "prettier --check ." | |||
"fmt:check": "prettier --check .", | |||
"test:jsr": "npm run test:jsr --workspaces --if-present" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding test:jsr
to the ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting a few days before merging.
This simplifies the generation of type definitions.
// @ts-self-types
comment to specify types in the rolled-up packages, eliminating the need for a separate step to add a triple-slash directive.tsconfig.cjs.json
configurations. It turns out we can just copy overindex.d.ts
toindex.d.cts
and TypeScript will be happy.