-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: do not publish ts files to npm #21
Conversation
this is to exclude ts files when publishing to npm.
adba31f
to
3bdb547
Compare
@@ -14,7 +14,7 @@ | |||
} | |||
}, | |||
"files": [ | |||
"dist" | |||
"dist/**/*.{js,cjs,mjs,d.ts}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mjs
was not used; it was included in case there may be some mjs files later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see this line; have you pulled the latest changes?
just pushed a commit: 3baee87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still would need the ts file after resolving to .js
the import inside the d.ts
is actually resolving to types.ts
and not types.js
. Try looking at the compat build files once 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, good catch! seems it's always required (not only jsr as described in #16 (comment)).
this is to exclude ts files when publishing to npm.
npm:
refs: #16 (comment)
jsr: