-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Directive and DirectiveType #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably also want to re-export Directive
here:
rewrite/packages/plugin-kit/src/index.js
Lines 7 to 11 in c95ba1f
export { | |
CallMethodStep, | |
VisitNodeStep, | |
TextSourceCodeBase, | |
} from "./source-code.js"; |
Oops, correct! |
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
Add
Directive
class to@eslint/plugin-kit
. (Extracted from the core.)What changes did you make? (Give an overview)
Directive
class to@eslint/plugin-kit
to be used when implementingSourceCode#getDisableDirectives()
DirectiveType
type to@eslint/core
Directive#node
to be typeunknown
instead ofobject
to force consumers to type cast the value before using it.Directive
Related Issues
Is there anything you'd like reviewers to focus on?