Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export ObjectSchema #101

Merged
merged 1 commit into from
Aug 9, 2024
Merged

feat: Export ObjectSchema #101

merged 1 commit into from
Aug 9, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 8, 2024

Prerequisites checklist

What is the purpose of this pull request?

Export ObjectSchema from the package. I'm working on some changes in the core where I need an instance of ObjectSchema, and even though the package is a dependency of @eslint/config-array, @eslint/object-schema isn't listed in package.json, which fails our lint check.

What changes did you make? (Give an overview)

Exported ObjectSchema as a passthrough from @eslint/object-schema.

Related Issues

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Member Author

nzakas commented Aug 8, 2024

@aladdin-add just a reminder, when you approve a PR and don't merge it, please leave a message as to why you didn't merge it.

@nzakas nzakas mentioned this pull request Aug 8, 2024
1 task
@aladdin-add
Copy link
Member

I didn't merge it as I would like another review before merging. :)

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit f149f85 into main Aug 9, 2024
14 checks passed
@fasttime fasttime deleted the object-schema-export branch August 9, 2024 16:35
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants