Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request: Remove ConfigArray#isExplicitMatch() #51

Closed
2 of 5 tasks
mdjermanovic opened this issue Jun 7, 2024 · 1 comment · Fixed by #53
Closed
2 of 5 tasks

Change Request: Remove ConfigArray#isExplicitMatch() #51

mdjermanovic opened this issue Jun 7, 2024 · 1 comment · Fixed by #53
Assignees
Labels

Comments

@mdjermanovic
Copy link
Member

Which packages would you like to change?

  • @eslint/compat
  • @eslint/config-array
  • @eslint/migrate-config
  • @eslint/object-schema

What problem do you want to solve?

ConfigArray#isExplicitMatch() is out of sync with the rest of the logic of config-array, and we're not using this method in ESLint anymore.

What do you think is the correct solution?

Remove ConfigArray#isExplicitMatch() method.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@mdjermanovic mdjermanovic added enhancement New feature or request breaking labels Jun 7, 2024
@nzakas nzakas added the accepted label Jun 7, 2024
@nzakas
Copy link
Member

nzakas commented Jun 7, 2024

Makes sense to me. There's a bunch of other logic I think we can remove now, too, specifically around including functions and arrays in the array. We're not using those features, so I don't think it makes sense to leave them in at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants