Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented May 6, 2025

Prerequisites checklist

What is the purpose of this pull request?

Hello,

I’ve finished implementing no-duplicate-definitions.

I’ve left some comments on some notable parts of the code.

What changes did you make? (Give an overview)

I’ve finished implementing no-duplicate-definitions.

Related Issues

closes: #358

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir self-assigned this May 9, 2025
@lumirlumir lumirlumir added this to Triage May 9, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage May 9, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage May 9, 2025

defaultOptions: [
{
ignoreDefinition: ["//"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lumirlumir lumirlumir marked this pull request as ready for review May 13, 2025 13:58
@lumirlumir lumirlumir requested review from fasttime and nzakas May 13, 2025 14:43
@lumirlumir lumirlumir marked this pull request as draft May 15, 2025 10:52
@lumirlumir lumirlumir marked this pull request as ready for review May 16, 2025 10:14
nzakas
nzakas previously approved these changes May 16, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Would like @fasttime to review before merging.

@nzakas nzakas moved this from Implementing to Second Review Needed in Triage May 16, 2025
@lumirlumir lumirlumir marked this pull request as draft May 19, 2025 10:27
@lumirlumir
Copy link
Member Author

@nzakas @fasttime @snitin315

Thanks for all your reviews! I've pushed a few more commits.

@lumirlumir lumirlumir marked this pull request as ready for review May 19, 2025 12:18
nzakas
nzakas previously approved these changes May 19, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @fasttime and @snitin315 to verify their feedback before merging.

snitin315
snitin315 previously approved these changes May 20, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a small suggestion, totally optional and not blocking the merge.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

@nzakas nzakas merged commit 18c7d77 into eslint:main May 21, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage May 21, 2025
@lumirlumir lumirlumir deleted the patch-1 branch May 21, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

New Rule: no-duplicate-definitions

4 participants