Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented May 31, 2025

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've created dedicated documentation for JSON.

It was briefly discussed in #104 (comment).

I've also updated rule's URL and ESLint config file accordingly.

What changes did you make? (Give an overview)

I've created dedicated documentation for JSON.

Related Issues

Is there anything you'd like reviewers to focus on?

I'll take a look at the rule section automation in README.md once this PR is accepted.

@eslint-github-bot eslint-github-bot bot added the documentation Improvements or additions to documentation label May 31, 2025
@lumirlumir lumirlumir marked this pull request as draft May 31, 2025 10:51
@lumirlumir lumirlumir force-pushed the docs-create-dedicated-docs-for-json branch from 6ff0be3 to 246837c Compare June 3, 2025 13:22
@lumirlumir lumirlumir marked this pull request as ready for review June 5, 2025 10:23
@lumirlumir lumirlumir added this to Triage Jun 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 5, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this. I left some suggestions to clarify things and to ensure consistent formatting across plugin rule docs.

@nzakas nzakas moved this from Needs Triage to Implementing in Triage Jun 5, 2025
lumirlumir and others added 14 commits June 7, 2025 13:07
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
@lumirlumir
Copy link
Member Author

@nzakas Thanks for your suggestions. I’ve addressed all the reviews.

@lumirlumir lumirlumir requested a review from nzakas June 7, 2025 04:23
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 8d97616 into main Jun 9, 2025
20 checks passed
@nzakas nzakas deleted the docs-create-dedicated-docs-for-json branch June 9, 2025 15:09
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted documentation Improvements or additions to documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants