Chore: use precalculated counts in stylish formatter #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alberto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgol, @sindresorhus and @mysticatea to be potential reviewers. |
|
LGTM |
gyandeeps
approved these changes
Mar 14, 2017
lib/formatters/stylish.js
Outdated
| @@ -74,6 +74,8 @@ module.exports = function(results) { | |||
| ).split("\n").map(el => el.replace(/(\d+)\s+(\d+)/, (m, p1, p2) => chalk.dim(`${p1}:${p2}`))).join("\n")}\n\n`; | |||
| }); | |||
|
|
|||
| total = errors + warnings; | |||
There was a problem hiding this comment.
Could total be declared with const instead of let?
alberto
force-pushed
the
stylish-cleanup
branch
from
d31efd3 to
1dd6bfa
Compare
|
LGTM |
not-an-aardvark
approved these changes
Mar 14, 2017
vitorbal
approved these changes
Mar 15, 2017
There was a problem hiding this comment.
LGTM. FWIW, the codeframe formatter could also be updated to use the precalculated counts: https://github.com/eslint/eslint/blob/master/lib/formatters/codeframe.js#L105-L109
This was referenced Mar 17, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
Use the precalculated error and warning count in stylish
Is there anything you'd like reviewers to focus on?
Is there a reason why we weren't doing this before?