Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove no-inner-declarations from eslint:recommended #17920

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs #15576

What changes did you make? (Give an overview)

Removed no-inner-declarations rule from the eslint:recommended configuration.

I also ran the script to update rules data files for the docs site, to include all recent changes.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 29, 2023 16:47
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Dec 29, 2023
Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b6d1043
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658ef82c78fd9100081cb89e
😎 Deploy Preview https://deploy-preview-17920--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 29, 2023
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit baff28c into main Dec 29, 2023
17 checks passed
@nzakas nzakas deleted the recommended-no-inner-declaration branch December 29, 2023 18:41
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 27, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible feature This change adds a new feature to ESLint
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants