-
-
Notifications
You must be signed in to change notification settings - Fork 75
chore: update codemirror #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Looks good to me on my end; everything seems to be working as expected.
That said, I'm not very familiar with the CodeMirror ecosystem, another review would be helpful.
Prerequisites checklist
What is the purpose of this pull request?
This pull request migrates the codebase from the legacy CodeMirror 0.19.x packages to the stable CodeMirror v6 release.
What changes did you make? (Give an overview)
@codemirror/highlight,@codemirror/tooltip,@codemirror/panel, etc.) with their v6 equivalents.ecmaFeatures.jsxis true@uiw/react-codemirrorfrom 4.5.1 → ^4.25.2.Related Issues
Closes #760
Is there anything you'd like reviewers to focus on?