Skip to content

fix: auto assign is not working correctly #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix: auto assign is not working correctly #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cae330
fix: auto assign is not working correctly
lumirlumir Jun 2, 2025
5c7f7b7
wip
lumirlumir Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/auto-assign/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function isWillingToSubmitPR(body) {
return body
.toLowerCase()
.includes(
"- [x] i am willing to submit a pull request to implement this change."
"- [x] i am willing to submit a pull request"
);
}

Expand Down
116 changes: 67 additions & 49 deletions tests/plugins/auto-assign/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,21 @@ const autoAssign = require("../../../src/plugins/auto-assign");
// Helpers
//-----------------------------------------------------------------------------

const API_ROOT = "https://api.github.com";
const API_URL = "https://api.github.com/repos/test/repo-test/issues/1/assignees";

/**
* Returns an array of strings representing the issue body.
* @param {'x' | ''} checkMark Check mark to use in the issue body.
* @returns {string[]} Array of strings representing the issue body.
*/
function issueBodies(checkMark) {
return [
`- [${checkMark}] I am willing to submit a pull request for this issue.`,
`- [${checkMark}] I am willing to submit a pull request for this change.`,
`- [${checkMark}] I am willing to submit a pull request to implement this rule.`,
`- [${checkMark}] I am willing to submit a pull request to implement this change.`
]
}

//-----------------------------------------------------------------------------
// Tests
Expand All @@ -37,6 +51,11 @@ describe("auto-assign", () => {
});

autoAssign(bot);

fetchMock.mockGlobal().post(
API_URL,
{ status: 200 }
);
});

afterEach(() => {
Expand All @@ -47,62 +66,61 @@ describe("auto-assign", () => {

describe("issue opened", () => {
test("assigns issue to author when they indicate willingness to submit PR", async () => {
fetchMock.mockGlobal().post(
`${API_ROOT}/repos/test/repo-test/issues/1/assignees`,
{ status: 200 }
);

await bot.receive({
name: "issues",
payload: {
action: "opened",
installation: {
id: 1
},
issue: {
number: 1,
body: "- [x] I am willing to submit a pull request to implement this change.",
user: {
login: "user-a"
}
},
repository: {
name: "repo-test",
owner: {
login: "test"
for (const body of issueBodies("x")) {
await bot.receive({
name: "issues",
payload: {
action: "opened",
installation: {
id: 1
},
issue: {
number: 1,
body,
user: {
login: "user-a"
}
},
repository: {
name: "repo-test",
owner: {
login: "test"
}
}
}
}
});
});

expect(fetchMock.callHistory.called(`${API_ROOT}/repos/test/repo-test/issues/1/assignees`)).toBeTruthy();
expect(fetchMock.callHistory.called(API_URL)).toBeTruthy();
}
});

test("does not assign issue when author does not indicate willingness to submit PR", async () => {
await bot.receive({
name: "issues",
payload: {
action: "opened",
installation: {
id: 1
},
issue: {
number: 1,
body: "- [] I am willing to submit a pull request to implement this change.",
user: {
login: "user-a"
}
},
repository: {
name: "repo-test",
owner: {
login: "test"
for (const body of issueBodies("")) {
await bot.receive({
name: "issues",
payload: {
action: "opened",
installation: {
id: 1
},
issue: {
number: 1,
body,
user: {
login: "user-a"
}
},
repository: {
name: "repo-test",
owner: {
login: "test"
}
}
}
}
});
});

expect(fetchMock.callHistory.called()).toBe(false);
expect(fetchMock.callHistory.called(API_URL)).toBe(false);
}
});
});
});
});