Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 15, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR follows up on eslint/css#330.

In this PR, I've ensured the auto-created release-please action triggers CI.

Problem

Currently, the auto-created PR from the release-please action does not trigger CI, as shown below:

For example: eslint/rewrite#336

image

This can result in CI not running and may lead to issues like eslint/rewrite#308 if the check is missing.

Solution

I've used secrets.WORKFLOW_PUSH_BOT_TOKEN instead of the default secrets.GITHUB_TOKEN, following the same approach described in eslint/css#330.

Also, the permissions for contents and pull-requests is no longer necessary because secrets.WORKFLOW_PUSH_BOT_TOKEN already grants the required permissions, so I removed it.

FYI: the token input reference: https://github.com/googleapis/release-please-action?tab=readme-ov-file#action-inputs

image

Test

I've tested it in my forked repository (using rewrite repository), and it works as expected:

lumirlumir/fork-rewrite#9

  • Before: CI wasn't running
스크린샷 2025-12-15 191430
  • After: CI is running
스크린샷 2025-12-15 191842

What changes did you make? (Give an overview)

This PR follows up on eslint/css#330.

In this PR, I've ensured the auto-created release-please action triggers CI.

Related Issues

Ref: eslint/css#330

Is there anything you'd like reviewers to focus on?

N/A

@eslintbot eslintbot added this to Triage Dec 15, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 15, 2025
@coveralls
Copy link

coveralls commented Dec 15, 2025

Pull Request Test Coverage Report for Build 20233054325

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.551%

Totals Coverage Status
Change from base Build 20089849670: 0.0%
Covered Lines: 11927
Relevant Lines: 12068

💛 - Coveralls

@lumirlumir lumirlumir marked this pull request as ready for review December 15, 2025 13:01
@lumirlumir lumirlumir requested a review from a team as a code owner December 15, 2025 13:01
Copilot AI review requested due to automatic review settings December 15, 2025 13:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release-please GitHub Actions workflow to ensure that auto-created PRs trigger CI checks. The change addresses an issue where release PRs were not running CI workflows, which could lead to undetected problems.

Key Changes:

  • Configured release-please action to use WORKFLOW_PUSH_BOT_TOKEN instead of the default GITHUB_TOKEN
  • Removed redundant contents: write and pull-requests: write permissions now covered by the bot token
  • Added formatting improvements with blank lines for better readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

release-please:
runs-on: ubuntu-latest
permissions:
contents: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

4 participants