-
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: skip validating values containing env() in no-invalid-properties #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−2
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e0c450f
fix: skip validation for values containing env() in no-invalid-proper…
minseonkkim 074dc17
test: add valid env() cases and unknown property with env() value
minseonkkim b8e522b
test: add case for env() with an otherwise-invalid value
minseonkkim de7057e
test: add invalid case for var() nested in env()
minseonkkim c127071
test: move env() cases after generic cases in no-invalid-properties
minseonkkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment: relying on an internal error message seems fragile because changes in
csstreecould break this check. Error messages are generally not a stable API and may vary between versions.Currently, there does not appear to be a reliable way to distinguish this unsupported
env()matching case from other generic errors, so checking the message may be the most practical option for now.In the longer term, introducing a custom error class -- similar to the existing
SyntaxReferenceErrorandSyntaxMatchError-- or exposing a stable error code such asERR_LEXER_ENV_MATCH_UNSUPPORTEDwould provide a more robust solution.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an error only our fork of csstree throws (reference for upstream), so we could add an error code to this, but we can do this after this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minseonkkim
If you’d like to open an issue about it, that would be welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened eslint/csstree#141 for this. Thanks for the suggestion!