Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Sep 23, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was motivated by eslint/json#140 (comment).

In this PR, I've updated the ESLint version requirement in README.md.

Because CSS uses meta.defaultOptions internally — which has been available since ESLint v9.15.0 — I've updated the documentation accordingly.

What changes did you make? (Give an overview)

In this PR, I've updated the ESLint version requirement in README.md.

Related Issues

Ref: eslint/json#140 (comment).

Is there anything you'd like reviewers to focus on?

N/A

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 23, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Improvements or additions to documentation label Sep 23, 2025
@DMartens
Copy link

Nice catch and changes LGTM, thanks.
Why does this plugin (and the other language plugins) not declare a peer dependency on eslint?
We currently recommend adding the peer dependency.

@mdjermanovic
Copy link
Member

Why does this plugin (and the other language plugins) not declare a peer dependency on eslint?

Explained here: eslint/json#25

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit e0c1f0f into main Sep 23, 2025
22 checks passed
@mdjermanovic mdjermanovic deleted the lumirlumir-patch-1 branch September 23, 2025 13:54
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants